fix: reset slider-captcha after login failed #6275

mynetfan · 2025-05-25T07:27:06Z

修复登陆时如果接口i返回登陆失败后，划动验证没有重置的问题。

Summary by CodeRabbit

Refactor
- Improved the login form's error handling for a smoother user experience. No visible changes to functionality.

changeset-bot · 2025-05-25T07:27:11Z

⚠️ No Changeset found

Latest commit: 34d36f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-05-25T07:27:15Z

Walkthrough

The update optimizes error handling in the login form submission by storing the form API instance in a local variable. This avoids redundant API calls when resetting the captcha field and resuming the captcha component, streamlining the error recovery process.

Changes

File	Change Summary
playground/src/views/_core/authentication/login.vue	Refactored error handling in `onSubmit` to use a local form API variable, reducing redundant calls when resetting captcha.

Poem

A hop and a skip, the login form's neat,
Now errors are handled with less repeat.
One call, not two, to fetch what we need,
The captcha resets at lightning speed.
With every small tweak, our code grows bright—
Rabbits love when things work right! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5c9373 and 34d36f6.

📒 Files selected for processing (1)

playground/src/views/_core/authentication/login.vue (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

GitHub Check: Check (windows-latest)
GitHub Check: Test (windows-latest)
GitHub Check: Analyze (javascript-typescript)
GitHub Check: Lint (ubuntu-latest)
GitHub Check: Lint (windows-latest)
GitHub Check: post-update (ubuntu-latest)
GitHub Check: post-update (windows-latest)

🔇 Additional comments (1)

playground/src/views/_core/authentication/login.vue (1)

114-120: LGTM! Excellent fix with performance optimization.

This change successfully addresses the slider captcha reset issue after login failure while also optimizing the code. The implementation:

Fixes the core issue: Properly resets the captcha field value and calls resume() on the component

Improves performance: Avoids redundant getFormApi() calls by storing the API instance in a local variable

Maintains safety: Uses optional chaining to handle potential null/undefined values

Follows logical sequence: Resets the field value before calling component resume

The approach of setting the captcha field to false without triggering validation (third parameter) and then calling the component's resume() method is the correct way to reset a slider captcha after failed authentication.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…into web * 'main' of https://github.com/baohaojie123/vue-vben-admin: fix: Update index.ts (vbenjs#6268) fix: reset slider-captcha after login failed (vbenjs#6275) fix: json-bigint parse used in vxeTable (vbenjs#6271) fix: repair the unexpected form default value (vbenjs#5567) feat: optimize logo display (vbenjs#6267) feat: improve check updates (vbenjs#6257) feat: enhances compatibility with APIs returning large numeric values (vbenjs#6250) fix: component Input is not registered when initialize page (vbenjs#6246) feat: ellipsis text automatically displays tooltip based on ellipsis (vbenjs#6244) # Conflicts: # apps/web-naive/src/adapter/form.ts # apps/web-naive/src/bootstrap.ts # docs/src/components/common-ui/vben-ellipsis-text.md

* 'main' of https://github.com/baohaojie123/vue-vben-admin: (35 commits) chore: release 5.5.7 feat: improve vbenCheckButtonGroup (vbenjs#6329) types: 扩展user-dropdown组件的menus类型，支持iconify (vbenjs#6283) fix: resolve onClosed method failure in connectedComponent of useVbenModal (vbenjs#6309) fix: 修复使用useVbenVxeGrid配置hasEmptyText、hasEmptyRender不生效的问题 (vbenjs#6310) fix: When defaultHomePage is inconsistent with user.homePath, the pa… (vbenjs#6299) docs(settings): 完善'生产环境动态配置'步骤 (vbenjs#6297) fix: alert width fixed in small screen (vbenjs#6312) style: fix lint error (vbenjs#6298) feat: support for hybrid permission access control mode (vbenjs#6294) fix: fix table-title slot not work (vbenjs#6295) fix: Update index.ts (vbenjs#6268) fix: reset slider-captcha after login failed (vbenjs#6275) fix: json-bigint parse used in vxeTable (vbenjs#6271) fix: repair the unexpected form default value (vbenjs#5567) feat: optimize logo display (vbenjs#6267) feat: improve check updates (vbenjs#6257) feat: enhances compatibility with APIs returning large numeric values (vbenjs#6250) fix: component Input is not registered when initialize page (vbenjs#6246) feat: ellipsis text automatically displays tooltip based on ellipsis (vbenjs#6244) ... # Conflicts: # apps/web-naive/src/adapter/form.ts # apps/web-naive/src/bootstrap.ts # docs/src/components/common-ui/vben-ellipsis-text.md # docs/src/en/guide/in-depth/access.md # docs/src/guide/essentials/build.md # docs/src/guide/essentials/route.md

fix: reset slider-captcha after login failed

34d36f6

mynetfan requested review from anncwb, jinmao88 and vince292007 as code owners May 25, 2025 07:27

mynetfan merged commit 6fbf138 into vbenjs:main May 25, 2025
15 checks passed

mynetfan deleted the fix/login-reset branch May 25, 2025 08:04

github-actions bot locked and limited conversation to collaborators Jun 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: reset slider-captcha after login failed #6275

fix: reset slider-captcha after login failed #6275

Uh oh!

mynetfan commented May 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented May 25, 2025

Uh oh!

coderabbitai bot commented May 25, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

fix: reset slider-captcha after login failed #6275

fix: reset slider-captcha after login failed #6275

Uh oh!

Conversation

mynetfan commented May 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented May 25, 2025

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented May 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

mynetfan commented May 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)