-
-
Notifications
You must be signed in to change notification settings - Fork 20
Fix for build issues #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for charming-faun-72b6b3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Netlify build passed after picking up the correct Node version in Line 18. No need to add environment variables separately. @santoshyadavdev Please check the deployed URL in case something is broken post-dependency upgrade, like the MDX output structure or image (which we don't seem to have in the project currently.) |
| "@astrojs/image": "^0.11.6", | ||
| "@astrojs/mdx": "^0.11.6", | ||
| "@astrojs/image": "^0.17.3", | ||
| "@astrojs/mdx": "~0.19.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have intentionally used ~0.19.6 (include patches) instead of ^0.19.6 (hard limit) to avoid potential conflicts. At the moment, there is no difference, and both will work. You may use ^ instead if you prefer that to be more strict.
|
Output of $ pnpm install
WARN deprecated [email protected]: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
Already up to date
Progress: resolved 661, reused 617, downloaded 0, added 0, done
WARN Issues with peer dependencies found
.
└─┬ astro-layouts 0.0.6
└── ✕ unmet peer astro@^1.6.7: found 2.10.11I couldn't find a proper reference of how and where astro-layouts are being used, but this is not causing any further build issues and I can preview it locally as well as can be seen in the Netlify URL: https://deploy-preview-52--charming-faun-72b6b3.netlify.app/ |
|
Awesome thank you, I can see the build succeeded. |
.nvmrcfiles automatically, so this works for now. For other providers, we would need to set NODE_VERSION=18 as an environment variable.@astro/[email protected]@astro/tailwind@4(minimum supported stable version)@astro/[email protected](this exact version is required, minimum)v5.4tov6.Fixes #51