vscode: allow trailing comma in bun.lock
#15747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(also make bun.lock type = jsonc as vscode stable isnt released yet)
Collaborator
RiskyMH
commented
Dec 13, 2024
| "title": "JSON schema for bun.lock files.", | ||
| "allowTrailingCommas": true, | ||
| "type": "object" | ||
| } No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
in future we can type this better like the actual intention of the schema, but for now just using it for allowTrailingCommas
There was a problem hiding this comment.
Maybe you could even submit this upstream in https://github.com/microsoft/vscode/tree/main/extensions/json-language-features. You can still add a more detailed JSON schema later here or in the JSON Schema Store. They’ll both be applied.
Contributor
Author
|
The warnings I am referring to are:
|
brainkim
pushed a commit
to brainkim/bun
that referenced
this pull request
Dec 18, 2024
heimskr
pushed a commit
that referenced
this pull request
Dec 31, 2024
probably-neb
pushed a commit
to probably-neb/bun
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes vscode show bun.lock as jsonc and suppress the trailing comma warnings. I also made the bun.lockb more strict so it wasnt matching any and all .lockb files.
There was pr adding the jsonc bit to vscode itself, but adding here as its not released yet: microsoft/vscode#235917
also fixes #15780