Skip to content

Add support for a border between sidebar and panel titles and views #157318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benibenj merged 12 commits into from
Nov 29, 2024
Merged

Add support for a border between sidebar and panel titles and views #157318

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
af9c59e
Add support for a border between sidebar and panel titles and views
a-stewart Aug 5, 2022
84449fa
Merge branch 'main' into view-location-title-border
a-stewart Oct 17, 2024
01eaf9e
Updates after merging
a-stewart Oct 17, 2024
6b89088
Add borders for aux panel too
a-stewart Oct 17, 2024
715e63d
Set box-sizing to content-box
a-stewart Oct 18, 2024
21e9b33
Set box-sizing to content-box
a-stewart Oct 18, 2024
630b71c
Remove fixed 35px height on .monaco-action-bar
a-stewart Oct 18, 2024
afe8bee
Remove box-sizing from panelPart.css
a-stewart Oct 18, 2024
54a2be6
Merge branch 'main' into view-location-title-border
a-stewart Oct 18, 2024
d93fa35
Merge branch 'main' into view-location-title-border
a-stewart Oct 21, 2024
b08d040
Merge branch 'main' into view-location-title-border
a-stewart Nov 1, 2024
96b21b5
Merge branch 'main' into view-location-title-border
benibenj Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add borders for aux panel too
  • Loading branch information
@a-stewart
a-stewart authored Oct 17, 2024
commit 6b8908833b519af7b37fee9772c6af205dc4fa80
4 changes: 2 additions & 2 deletions src/vs/workbench/browser/parts/auxiliarybar/auxiliaryBarPart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { IStorageService } from '../../../../platform/storage/common/storage.js'
import { contrastBorder } from '../../../../platform/theme/common/colorRegistry.js';
import { IThemeService } from '../../../../platform/theme/common/themeService.js';
import { ActiveAuxiliaryContext, AuxiliaryBarFocusContext } from '../../../common/contextkeys.js';
import { ACTIVITY_BAR_BADGE_BACKGROUND, ACTIVITY_BAR_BADGE_FOREGROUND, ACTIVITY_BAR_TOP_ACTIVE_BORDER, ACTIVITY_BAR_TOP_DRAG_AND_DROP_BORDER, ACTIVITY_BAR_TOP_FOREGROUND, ACTIVITY_BAR_TOP_INACTIVE_FOREGROUND, PANEL_ACTIVE_TITLE_BORDER, PANEL_ACTIVE_TITLE_FOREGROUND, PANEL_DRAG_AND_DROP_BORDER, PANEL_INACTIVE_TITLE_FOREGROUND, SIDE_BAR_BACKGROUND, SIDE_BAR_BORDER, SIDE_BAR_FOREGROUND } from '../../../common/theme.js';
import { ACTIVITY_BAR_BADGE_BACKGROUND, ACTIVITY_BAR_BADGE_FOREGROUND, ACTIVITY_BAR_TOP_ACTIVE_BORDER, ACTIVITY_BAR_TOP_DRAG_AND_DROP_BORDER, ACTIVITY_BAR_TOP_FOREGROUND, ACTIVITY_BAR_TOP_INACTIVE_FOREGROUND, PANEL_ACTIVE_TITLE_BORDER, PANEL_ACTIVE_TITLE_FOREGROUND, PANEL_DRAG_AND_DROP_BORDER, PANEL_INACTIVE_TITLE_FOREGROUND, SIDE_BAR_BACKGROUND, SIDE_BAR_BORDER, SIDE_BAR_TITLE_BORDER, SIDE_BAR_FOREGROUND } from '../../../common/theme.js';
import { IViewDescriptorService } from '../../../common/views.js';
import { IExtensionService } from '../../../services/extensions/common/extensions.js';
import { ActivityBarPosition, IWorkbenchLayoutService, LayoutSettings, Parts, Position } from '../../../services/layout/browser/layoutService.js';
Expand Down Expand Up @@ -101,7 +101,7 @@ export class AuxiliaryBarPart extends AbstractPaneCompositePart {
'auxiliarybar',
'auxiliarybar',
undefined,
undefined,
SIDE_BAR_TITLE_BORDER,
notificationService,
storageService,
contextMenuService,
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/browser/parts/panel/panelPart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export class PanelPart extends AbstractPaneCompositePart {
instantiationService,
themeService,
viewDescriptorService,
contextKeyService, // someting about borders
contextKeyService,
extensionService,
menuService,
);
Expand Down