Skip to content

feat: support hover tooltip for scss #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aeschli merged 5 commits into from
Feb 28, 2024
Merged

feat: support hover tooltip for scss #367

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
00621af
feat: support media in scss tooltip
balaji-sivasakthi Oct 6, 2023
aaf455c
test: hover media query in scss
balaji-sivasakthi Oct 6, 2023
cbc6149
fix: type issue
balaji-sivasakthi Oct 6, 2023
1adce32
Merge branch 'main' into balaji-sivasakthi/peaceful-guanaco
aeschli Feb 21, 2024
a6f7ec9
fix: `toString()` and code style
balaji-sivasakthi Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: type issue
  • Loading branch information
@balaji-sivasakthi
balaji-sivasakthi committed Oct 6, 2023
commit cbc6149c5738176bc45c0144a562058415ffd7b1
6 changes: 3 additions & 3 deletions src/services/cssHover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class CSSHover {
* Build up the hover by appending inner node's information
*/
let hover: Hover | null = null;
let flagOpts;
let flagOpts:{text:string;isMedia:boolean};

for (let i = 0; i < nodepath.length; i++) {
const node = nodepath[i];
Expand All @@ -48,13 +48,13 @@ export class CSSHover {
const matches = node.getText().match(regex);
flagOpts = {
isMedia:true,
text:matches?.[0]
text:matches?.[0].toString()!
Copy link
Collaborator

@aeschli aeschli Oct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toString()! is not necessary

Copy link
Contributor Author

@balaji-sivasakthi balaji-sivasakthi Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I removed it.

};
}

if (node instanceof nodes.Selector) {
hover = {
contents: this.selectorPrinting.selectorToMarkedString(<nodes.Selector>node, flagOpts),
contents: this.selectorPrinting.selectorToMarkedString(<nodes.Selector>node, flagOpts!),
range: getRange(node)
};
break;
Expand Down