Fix markdown preview scroll crawls at EOF (fix #249278) #251228
Merged
+0
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix scrolling of markdown preview at EOF. This PR fixes #249278.
Cause
scrollTois very small, less than 1, but the postprocessing scrolls more than necessary.This causes errors again, and to reduce this error,
scrollTois set in the opposite direction again.Resolve
First, I removed the logic that causes errors.
I checked the history at the time by finding the PR and Issue where the code was written. (457acf8, Fix scrolling of markdown preview. Close #65504 #111094)
The code was originally written intentionally to fix an old another scrolling issue.
However, I tested it myself, and the issue that was there before is no longer occurring.
Test
I have tested this PR with the document referenced by previous contributors https://github.com/jlelong/LaTeX-Workshop-wiki/blob/master/Hover.md.
Before
After
Test previous issue