Skip to content

Conversation

@orgads
Copy link
Contributor

@orgads orgads commented Mar 9, 2024

This reverts commit b79e884 and implements it with proper mocking.

@orgads
Copy link
Contributor Author

orgads commented Mar 9, 2024

@connor4312 @alexr00 I rewrote the tests, hopefully with good mocking this time.

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orgads, a big thank you for taking the time to re-add the tests! I'll wait to approve until I get your 👍 in case you want to use suiteSetup.

This reverts commit b79e884 and
implements it with proper mocking.
@orgads
Copy link
Contributor Author

orgads commented Mar 11, 2024

Thanks! That was really helpful.

Done, and the tests pass locally.

@alexr00 alexr00 added this to the March 2024 milestone Mar 11, 2024
@alexr00 alexr00 enabled auto-merge (squash) March 11, 2024 13:27
@alexr00 alexr00 merged commit 6bd027e into microsoft:main Mar 11, 2024
@orgads orgads deleted the tunnel-tests branch March 11, 2024 13:57
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants