fix “Semantic tokens that are not in ascending order will not be highlighted” #1467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… function is called in non-character stream order; it is eventually delta-encoded at build time
Contributor
Author
|
@microsoft-github-policy-service agree |
Member
|
Thanks for the PR. Highly appreciated. See my minor review comments. |
dbaeumer
requested changes
Apr 29, 2024
Contributor
Author
|
Thanks for the review. I will resolve it later |
Contributor
Author
|
@dbaeumer Hi. Please see my latest commit. Thanks. |
dbaeumer
approved these changes
May 6, 2024
chrmarti
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. This PR is to fix this issue.
The problem is that when
push()is called out of order,_datadoes not collect the input token correctly.So I add a non-delta-encoded data attribute
_dataNonDelta, which is used when thepush()function is called in non-character stream order; it is eventually delta-encoded inbuild()orbuildEdits().I hope this change doesn't affect any places that previously output_data.If
push()is called in order, we still use_dataand it works the same as before.For the implementation of _sortAndDeltaEncode, I refer to the vscode source code here