add copy selection as different formats and paste hexstring support #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
Author
|
As I wrote here #521 (comment), because of #521 I think now it makes sense to rename all occurrences of |
connor4312
reviewed
May 6, 2024
Member
connor4312
left a comment
There was a problem hiding this comment.
Thanks for the contribution, sorry for the late review. Some comments.
connor4312
reviewed
May 7, 2024
connor4312
reviewed
May 7, 2024
connor4312
reviewed
May 7, 2024
connor4312
reviewed
May 7, 2024
Member
connor4312
left a comment
There was a problem hiding this comment.
Couple more small comments!
tomilho
reviewed
May 8, 2024
connor4312
approved these changes
May 8, 2024
Member
|
thanks for the PR! |
joyceerhl
approved these changes
May 8, 2024
|
Has this change been released yet? I don't see mentioned of it in the CHANGELOG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #411 and #341.
I added a
copyAscommand accessible from the context menus when right-clicking within the webview.The different
copyAsfunctions incopyAs.tscome from here https://github.com/stef-levesque/vscode-hexdump.I’ve also introduced an encoding option that enables the pasting of hex strings, in addition to utf-8 and base64 strings.