Skip to content

Conversation

@nurbek0298
Copy link
Contributor

Hello, I'm adding support for markup attributes in Vue.

Emmet supports CSS modules both in JSX and Vue files, but at the moment, emmetHelper only passes markup.attributes and markup.valuePrefix for JSX. Support for Vue files would make it more convenient to use Emmet in VS Code.

Ref: emmetio/emmet#589 (comment)

@nurbek0298 nurbek0298 marked this pull request as ready for review March 26, 2024 11:45
@nurbek0298
Copy link
Contributor Author

nurbek0298 commented Apr 4, 2024

@rzhao271 @daviddossett ping

@rzhao271 rzhao271 self-assigned this Apr 4, 2024
@rzhao271 rzhao271 self-requested a review April 4, 2024 16:14
@rzhao271 rzhao271 added this to the April 2024 milestone Apr 4, 2024
@rzhao271 rzhao271 merged commit a6ba695 into microsoft:main Apr 5, 2024
@nurbek0298 nurbek0298 deleted the vue-markup-attr branch April 6, 2024 18:08
@nurbek0298 nurbek0298 mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants