Misleading "Successfully merged" status when PR modifies incomplete file #181929
Replies: 1 comment 2 replies
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
Bug
Feature Area
Issues
Body
Description
When merging Pull Requests that modify an incomplete file (e.g., a truncated
index.html), GitHub displays "Successfully merged" even though the resulting file remains incomplete.This creates a false positive that misleads users into thinking the full intended content has been applied.
Steps to Reproduce
index.htmlthat is truncated at line 1000 (missing closing tags, JavaScript code, etc.)Expected Behavior
GitHub should warn users when:
Actual Behavior
Real-World Impact
In my repository
avvstancamarcello/LHISA-lecce-Italy-salento:index.html) was truncated at line 1000Proposed Solutions
Option 1: File Integrity Checks
Add warnings when merging to files with:
<script>without</script>)Option 2: Merge Status Clarification
Change status message to:
Guidelines
Beta Was this translation helpful? Give feedback.
All reactions